Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Better error message is proto is invalid. #628

Conversation

ChrisCummins
Copy link
Contributor

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 17, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2022

Codecov Report

Merging #628 (b4217a9) into development (c5b9289) will decrease coverage by 0.12%.
The diff coverage is 60.00%.

@@               Coverage Diff               @@
##           development     #628      +/-   ##
===============================================
- Coverage        88.75%   88.63%   -0.13%     
===============================================
  Files              115      115              
  Lines             7019     7024       +5     
===============================================
- Hits              6230     6226       -4     
- Misses             789      798       +9     
Impacted Files Coverage Δ
compiler_gym/views/observation_space_spec.py 84.84% <60.00%> (-4.44%) ⬇️
compiler_gym/envs/llvm/datasets/cbench.py 79.42% <0.00%> (-1.09%) ⬇️
...loop_tool/service/loop_tool_compilation_session.py 89.79% <0.00%> (-0.69%) ⬇️
compiler_gym/envs/compiler_env.py 91.85% <0.00%> (-0.50%) ⬇️
compiler_gym/envs/gcc/service/gcc_service.py 96.70% <0.00%> (-0.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5b9289...b4217a9. Read the comment docs.

@ChrisCummins ChrisCummins merged commit d22fd36 into facebookresearch:development Mar 17, 2022
@ChrisCummins ChrisCummins deleted the feature/observation-space-spec-errors branch March 17, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants