Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build hang by removing USES_TERMINAL from Programl Cmake command #703

Conversation

mostafaelhoushi
Copy link
Contributor

On my local Linux VM, it seems that removing USES_TERMINAL solves the problem of that 3 hour hang after bazel build.
This was based on an uneducated guess :) Let's see if CI will speedup

Fixes #566

On my local Linux VM, it seems that removing USES_TERMINAL solves the problem of that 3 hour hang after bazel build
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2022

Codecov Report

Merging #703 (2463ecd) into development (45fb0a0) will decrease coverage by 0.35%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           development     #703      +/-   ##
===============================================
- Coverage        88.70%   88.35%   -0.36%     
===============================================
  Files              131      131              
  Lines             7926     7926              
===============================================
- Hits              7031     7003      -28     
- Misses             895      923      +28     
Impacted Files Coverage Δ
...ompiler_gym/service/client_service_compiler_env.py 87.94% <0.00%> (-2.92%) ⬇️
compiler_gym/views/observation_space_spec.py 82.85% <0.00%> (-2.86%) ⬇️
compiler_gym/views/observation.py 97.29% <0.00%> (-2.71%) ⬇️
compiler_gym/service/service_cache.py 89.47% <0.00%> (-2.64%) ⬇️
compiler_gym/envs/llvm/llvm_benchmark.py 90.97% <0.00%> (-2.09%) ⬇️
compiler_gym/util/runfiles_path.py 89.28% <0.00%> (-1.79%) ⬇️
compiler_gym/envs/llvm/datasets/cbench.py 79.06% <0.00%> (-1.45%) ⬇️
compiler_gym/service/connection.py 76.66% <0.00%> (-1.00%) ⬇️
compiler_gym/envs/gcc/gcc.py 93.14% <0.00%> (-0.26%) ⬇️
...loop_tool/service/loop_tool_compilation_session.py 90.54% <0.00%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45fb0a0...2463ecd. Read the comment docs.

@mostafaelhoushi
Copy link
Contributor Author

build-linux-cmake now takes 34 minutes!
image

@mostafaelhoushi mostafaelhoushi changed the title remove USES_TERMINAL from bazel Cmake command Fix build hang by removing USES_TERMINAL from Programl Cmake command Jun 9, 2022
@ChrisCummins
Copy link
Contributor

Superstar! Thank you @mostafaelhoushi

@ChrisCummins
Copy link
Contributor

@ChrisCummins ChrisCummins merged commit 5912cac into facebookresearch:development Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CMake build gets stuck on ProGraML bazel step
4 participants