-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for granular timeouts #716
Add support for granular timeouts #716
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Ricardo,
Thanks for working on this! I left a couple of comments inline. Also, it would be great if you add tests to cover this new param, perhaps by mocking the underling call to env.service
to check that the parameter is forwarded correctly.
Please ignore the failing CI/www
jobs, it is a known issue and can be ignore #709.
Cheers,
Chris
Codecov Report
@@ Coverage Diff @@
## development #716 +/- ##
===============================================
- Coverage 88.72% 88.63% -0.09%
===============================================
Files 131 131
Lines 7935 7936 +1
===============================================
- Hits 7040 7034 -6
- Misses 895 902 +7
Continue to review full report at Codecov.
|
I'll work on the tests. Should I add them to the |
Thanks @ricardoprins!
Yep, that sounds like a good idea. Cheers, |
LGTM, thanks @ricardoprins! Cheers, |
Fixes #283.