[tests] Minimize the fork regression tests. #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #754 +/- ##
===============================================
+ Coverage 80.46% 82.11% +1.65%
===============================================
Files 131 131
Lines 7995 8008 +13
===============================================
+ Hits 6433 6576 +143
+ Misses 1562 1432 -130
|
This wrote a simple routine minimize_fork_regression_testcase() that takes as input a forked regression test and iteratively attempts to remove each of the actions that do not prevent the test from failing. Running this on the five known regression tests simplifies them dratically. In all but one case, they are simplified to a single pre-fork and single post-fork action. I'll dig more into the details of what's going on in later. Issue facebookresearch#749.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wrote a simple routine minimize_fork_regression_testcase() that
takes as input a forked regression test and iteratively attempts to
remove each of the actions that do not prevent the test from failing.
Running this on the five known regression tests simplifies them
dratically. In all but one case, they are simplified to a single
pre-fork and single post-fork action.
I'll dig more into the details of what's going on in later.
Issue #749.