Skip to content

Conversation

@Adesoji1
Copy link
Contributor

  • Created Dockerfile, entrypoint.sh, picture folder and .dockerignore in the root directory
  • Added test.md with detailed instructions on Docker setup and how to test the Docker container
  • Documented all testing procedures within test.md
  • Included a screenshot of the successful Docker build and test of docker container run in the pictures folder

- Created Dockerfile, entrypoint.sh, picture folder and .dockerignore in the root directory
- Added test.md with detailed instructions on Docker setup and how to test the Docker container
- Documented all testing procedures within test.md
- Included a screenshot of the successful Docker build and test of docker container run  in the pictures folder
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 25, 2024
Copy link
Collaborator

@mostafaelhoushi mostafaelhoushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Adesoji1 for working on this great feature! I highly appreciate that.
I am personally not familiar with Docker so it is great you added this functionality.

Happy to merge this PR but I am wondering if you would like to add to the README a small section about the Docker and point it to "test.md"?

I am not familiar with the conventions of Docker instructions, but was wondering if it is a good idea to rename test.md to docker.md or DOCKER.md?

Thanks again!

@Adesoji1
Copy link
Contributor Author

Adesoji1 commented Oct 25, 2024 via email

@mostafaelhoushi mostafaelhoushi merged commit 159ed05 into facebookresearch:main Oct 25, 2024
1 check passed
@mostafaelhoushi
Copy link
Collaborator

Sure @Adesoji1 ! Thanks for explaining the importance of dockers. I just merged the PR.
So you can create a separate PR. Also do you think it's a good idea to name the file with upper case letters (DOCKER.md) to be consistent with the existing README.md file?

@Adesoji1
Copy link
Contributor Author

Adesoji1 commented Oct 25, 2024 via email

@Adesoji1 Adesoji1 mentioned this pull request Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants