-
Notifications
You must be signed in to change notification settings - Fork 32
Add Docker setup and testing documentation #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adesoji1
commented
Oct 25, 2024
- Created Dockerfile, entrypoint.sh, picture folder and .dockerignore in the root directory
- Added test.md with detailed instructions on Docker setup and how to test the Docker container
- Documented all testing procedures within test.md
- Included a screenshot of the successful Docker build and test of docker container run in the pictures folder
- Created Dockerfile, entrypoint.sh, picture folder and .dockerignore in the root directory - Added test.md with detailed instructions on Docker setup and how to test the Docker container - Documented all testing procedures within test.md - Included a screenshot of the successful Docker build and test of docker container run in the pictures folder
mostafaelhoushi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Adesoji1 for working on this great feature! I highly appreciate that.
I am personally not familiar with Docker so it is great you added this functionality.
Happy to merge this PR but I am wondering if you would like to add to the README a small section about the Docker and point it to "test.md"?
I am not familiar with the conventions of Docker instructions, but was wondering if it is a good idea to rename test.md to docker.md or DOCKER.md?
Thanks again!
|
Thank you @mostafaelhoushi . Yes, I could do that, I will reference the
docker instructions to run the project and also rename test.md to docker.md
in another pull request so you could merge, is this ok with you? In
addition, Docker ensures that the application could be packaged into a
container. containers offer a high level of isolation between applications
and their dependencies. Each container runs independently, which means that
it will not interfere with other containers on the same machine or server.
This is crucial to ensure the security and stability of applications in
shared environments.
…On Fri, 25 Oct 2024, 1:35 pm Mostafa Elhoushi, ***@***.***> wrote:
***@***.**** approved this pull request.
Thank you @Adesoji1 <https://github.com/Adesoji1> for working on this
great feature! I highly appreciate that.
I am personally not familiar with Docker so it is great you added this
functionality.
Happy to merge this PR but I am wondering if you would like to add to the
README a small section about the Docker and point it to "test.md"?
I am not familiar with the conventions of Docker instructions, but was
wondering if it is a good idea to rename test.md to docker.md or DOCKER.md
?
Thanks again!
—
Reply to this email directly, view it on GitHub
<#12 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE4COXD2IEAVWLYDBCADES3Z5I3HVAVCNFSM6AAAAABQSZK4P6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGOJVGE2TINJWHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Sure @Adesoji1 ! Thanks for explaining the importance of dockers. I just merged the PR. |
|
Sure @mostafaelhoushi, I will do just that, Thank you
…On Fri, 25 Oct 2024, 5:08 pm Mostafa Elhoushi, ***@***.***> wrote:
Sure @Adesoji1 <https://github.com/Adesoji1> ! Thanks for explaining the
importance of dockers. I just merged the PR.
So you can create a separate PR. Also do you think it's a good idea to
name the file with upper case letters (DOCKER.md) to be consistent with the
existing README.md file?
—
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE4COXCKYQBWXAZYRU45HWDZ5JUIRAVCNFSM6AAAAABQSZK4P6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZYGIZDENRTGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|