-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embracing Poetry: includes version + deps bump #779
Conversation
Codecov Report
@@ Coverage Diff @@
## main #779 +/- ##
=======================================
Coverage 64.57% 64.57%
=======================================
Files 107 107
Lines 9259 9259
=======================================
Hits 5979 5979
Misses 3280 3280 Continue to review full report at Codecov.
|
Seems like there are a bunch of test failures - possible that the dependencies in pyproject.toml aren't up to date? |
Will this mean https://github.com/facebookresearch/Mephisto/search?q=pip+install |
Debugging the tests, but |
Alright solved the issue by commenting out the fancy poetry 1.2 syntax, will return to that when the release is finally cut. |
Overview
Preparing for the release of
1.0.2
, this PR moves us to fully adoptpoetry
as our python package manager. This is handled by moving all of the details that used to be insetup.py
,requirements.txt
, andMANIFEST.in
into thepyproject.toml
file. We're adapting this as we needed editable installations withpip install -e .
as described in python-poetry/poetry#34, and following python-poetry/poetry-core#182 we could actually have it. A year late, but eventually is better than never!After this it should be easier to modify and manage packages, and to deal with ParlAI dependencies (perhaps we can push them to adopt as well?).
Should resolve #818 and #768.
Note - some of the
pyproject.toml
file is still commented out. This is because there's some nicer syntax coming out in poetry 1.2 that I'd like to adopt, but I can't get tests to work using it just yet so I've left it commented out.