-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated react and react-dom #899
Conversation
@pringshia any thoughts on how we deal with react versions in Mephisto? Has been an issue for other projects as well |
This PR includes quite a bit of package version updates which I'm hesitant on merging right away, as there could be unintended behavior, the currently breaking tests aside. To back up a bit, what part of the prior version of |
Lack of |
@@ -24,9 +24,9 @@ jobs: | |||
steps: | |||
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it | |||
- uses: actions/checkout@v2 | |||
- uses: actions/setup-node@v2 | |||
- uses: actions/setup-node@v3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is causing tests to fail due to the following issue: actions/setup-node#317
Given the node version bump in the GH runner, seems like we'll also need to update yarn to version 3.2.2+ to fix the issue seen here:
|
Following up on this, I think you should just be able to relax the peerDependency requirement for |
Resolved with #905 |
Hi, @JackUrb! I needed to update react and react-dom for the compression task. Let me know if this works.
cc: @mmuckley