don't crash if a value can't be serialized (#3591)

facebookresearch · Apr 15, 2021 · 2f48dcd · 2f48dcd
1 parent 5740a39
commit 2f48dcd
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/parlai/utils/conversations.py b/parlai/utils/conversations.py
@@ -336,7 +336,7 @@ def save_conversations(
                             convo['context'].append(turn)
                     if new_pair:
                         convo['dialog'].append(new_pair)
-                json_convo = json.dumps(convo)
+                json_convo = json.dumps(convo, default=lambda v: '<not serializable>')
                 f.write(json_convo + '\n')
         logging.info(f'Conversations saved to file: {to_save}')