dyn

parlai/agents/fid/fid.py

@@ -348,7 +348,13 @@ def __init__(self, opt: Opt, shared: TShared = None):
                 'GoldDocRetrieverFiDAgent only works with `rag_retriever_query` being `"full_history"`. '
                 f'Changing opt value for `rag_retriever_query`: `"{prev_sel}"` -> `"full_history"`'
             )
-
+        if (
+            opt['dynamic_batching'] == 'full'
+            or opt.get('eval_dynamic_batching') == 'full'
+        ):
+            raise RuntimeError(
+                "For now dynamic batching doesn't work with ObservationEchoRetriever as it cleans up _saved_docs mapping after each batch act."
+            )
         super().__init__(opt, shared=shared)
 
     @abstractmethod
@@ -377,10 +383,13 @@ def _set_query_vec(self, observation: Message) -> Message:
         super()._set_query_vec(observation)
 
     def batch_act(self, observations):
-        output = super().batch_act(observations)
+        """
+        Clear the _saved_docs and _query_ids mappings in ObservationEchoRetriever
+        """
+        batch_reply = super().batch_act(observations)
         if hasattr(self.model_api.retriever, 'clear_mapping'):
             self.model_api.retriever.clear_mapping()
-        return output
+        return batch_reply
 
 
 class WizIntGoldDocRetrieverFiDAgent(GoldDocRetrieverFiDAgent):