Generalize a little.

facebookresearch · Aug 29, 2020 · 6b4074b · 6b4074b
1 parent 18bfd46
commit 6b4074b
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/parlai/utils/logging.py b/parlai/utils/logging.py
@@ -47,7 +47,7 @@
 }
 
 
-def _is_color_friendly():
+def _is_interactive():
     try:
         __IPYTHON__
         return True
@@ -79,14 +79,14 @@ def __init__(
 
     def _build_formatter(self):
         prefix_format = f'{self.prefix} ' if self.prefix else ''
-        if COLORED_LOGS and sys.stdout.isatty():
+        if COLORED_LOGS and _is_interactive():
             return coloredlogs.ColoredFormatter(
                 prefix_format + COLORED_FORMAT,
                 datefmt=CONSOLE_DATE_FORMAT,
                 level_styles=COLORED_LEVEL_STYLES,
                 field_styles={},
             )
-        elif sys.stdout.isatty():
+        elif _is_interactive():
             return logging.Formatter(
                 prefix_format + CONSOLE_FORMAT, datefmt=CONSOLE_DATE_FORMAT,
             )