Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Batch & Output objects #1437

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Batch & Output objects #1437

merged 1 commit into from
Feb 12, 2019

Conversation

alexholdenmiller
Copy link
Member

it's fully compatible with any code not subclassing batch, I think

Copy link
Contributor

@emilydinan emilydinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

discussed offline, but this looks nice to me!

@stephenroller stephenroller changed the title batch / output objects Batch & Output objects Feb 11, 2019
@stephenroller
Copy link
Contributor

Before this merges I'd like to convert one of the model extensions that subclass batch.

@alexholdenmiller alexholdenmiller merged commit 878df98 into master Feb 12, 2019
@stephenroller stephenroller deleted the batch_object branch February 12, 2019 22:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants