Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Distributed Evaluation #2775

Merged
merged 6 commits into from
Jul 16, 2020
Merged

Distributed Evaluation #2775

merged 6 commits into from
Jul 16, 2020

Conversation

stephenroller
Copy link
Contributor

Patch description
Allow for sped up evaluation via distributed evaluation.

Involves a refactor of distributed.

Testing steps
Manual testing. New CI.

@github-actions
Copy link

Your PR contains a change to a task. Please paste the results of the following command into a comment:

python tests/datatests/test_new_tasks.py

@emilydinan
Copy link
Contributor

CC @wyshi

@stephenroller stephenroller marked this pull request as ready for review July 15, 2020 18:50
@stephenroller
Copy link
Contributor Author

Ready for review. It looks like a bigger diff than it is, mostly because of a refactor.

@stephenroller stephenroller requested a review from dexterju27 July 16, 2020 00:07
Copy link
Contributor

@EricMichaelSmith EricMichaelSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to have! Approved but with some comments. Maybe it'd be good to see the results of python tests/datatests/test_new_tasks.py just in case?

parlai/scripts/multiprocessing_eval.py Outdated Show resolved Hide resolved
parlai/scripts/multiprocessing_eval.py Show resolved Hide resolved
parlai/utils/distributed.py Outdated Show resolved Hide resolved
@stephenroller stephenroller merged commit 1a65ad0 into master Jul 16, 2020
@stephenroller stephenroller deleted the distributedeval branch July 16, 2020 19:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants