This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re: not building dictionary. You can do a hack like this: ParlAI/parlai/agents/hugging_face/gpt2.py Line 229 in ce0caf6
(Just set max_exs to 0 so it's not built) |
emilydinan
reviewed
Jun 24, 2020
|
emilydinan
reviewed
Jun 25, 2020
i moved the script to |
typing is failing on files i did not touch... |
stephenroller
approved these changes
Jun 29, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
BART Agent: https://arxiv.org/abs/1910.13461.
-m bart
, however it is recommended to specify--init-model zoo:bart/bart_large/model
or-mf zoo:bart/bart_large/model
so that a dictionary is not needlessly built.gelu
implementation for the one intorch.nn.functional
. This provides a speed-up of about 10%; see details in logs section.cc @jaseweston as I remember one of the interns might have wanted BART?
Testing steps
Add nightly
bart
test to see whether the model can be fine-tuned on an integration task.Most of the time is actually just loading the model.
Logs
Gelu trained with SGD
New gelu
old Gelu
Actual training with adam on 1 epoch of Convai2