This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[Dict] Add extra special tokens #2828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 9, 2020 14:48
|
test |
stephenroller
approved these changes
Jul 15, 2020
| return text | ||
|
|
||
| def add_special_tokens(self, dict_agent, special_tokens: List[str]): |
There was a problem hiding this comment.
Suggested change
| def add_special_tokens(self, dict_agent, special_tokens: List[str]): | |
| def add_special_tokens(self, dict_agent, special_tokens: List[str]): | |
| """ | |
| Add special tokens to the tokenizer and dict_agent. | |
| """ |
klshuster
approved these changes
Jul 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Add a utility for adding special tokens; currently only BytelevelBPE and the simple space/split tokenizers are supported. Special tokens are added via a CLI flag in torch agent, but can be added to the dictionary manually. A couple of a notes
decodeby default. I added a flag to turn this on. Curious to hear if others thing this should be on by default.I added a test to check that this works for bytelevelbpe.
I also added an implementation of resizing token embeddings for Transformer Generator Agent and a general utility to do this in Torch Agent and a test