This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[TGA] Option to block full context #2928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klshuster
requested review from
stephenroller,
EricMichaelSmith,
jaseweston and
emilydinan
EricMichaelSmith
approved these changes
Aug 3, 2020
parlai/core/torch_generator_agent.py
Outdated
| ctxt = batch.text_vec[batch_idx] | ||
| if self.beam_block_full_context: | ||
| full_ctxt = batch.observations[batch_idx].get('full_text_vec', ctxt) | ||
| if not isinstance(full_ctxt, torch.Tensor): |
There was a problem hiding this comment.
hmm - should it be if not isinstance(full_ctxt, torch.LongTensor): instead?
There was a problem hiding this comment.
sure, it's just a check that it's not a List; will update
stephenroller
approved these changes
Aug 4, 2020
|
Default is now |
EricMichaelSmith
approved these changes
Aug 4, 2020
| # from generating ngrams from model's context, which is limited | ||
| # by truncation parameters. Now, we block on full dialogue history. | ||
| if 'beam_block_full_context' not in opt_from_disk: | ||
| opt_from_disk['beam_block_full_context'] = False |
There was a problem hiding this comment.
Hmm should we perhaps print a message about this so that people know?
|
failing test is flaky and gpu tests are still broken; going to merge anyway (everything passed before, and nothing functionally changed besides |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Beam search context ngram blocking is currently limited by the text truncation for a given model (e.g. for Blender this is only 128 tokens). I've added a flag to allow context blocking throughout the whole dialogue history.
Testing steps
Added a test
Logs