Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Add encoding to "with open"s in teachers.py #2946

Merged
merged 1 commit into from
Aug 10, 2020
Merged

Conversation

stephenroller
Copy link
Contributor

@stephenroller stephenroller commented Aug 6, 2020

Patch description
Fixes #2945. Adds an explicit encoding parameter to a number of open in teachers.py.

Eventually we'll do others, but they can come with the PathManager patch.

Testing steps
CI.

@stephenroller stephenroller marked this pull request as ready for review August 7, 2020 04:12
Copy link
Contributor

@EricMichaelSmith EricMichaelSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@stephenroller stephenroller merged commit d2b776c into master Aug 10, 2020
@stephenroller stephenroller deleted the encodingpatch branch August 10, 2020 14:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in training: module 'parlai.tasks.fromfile.agents' has no attribute 'create_agents'
3 participants