Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Fixed a mistake in documentation for creating tasks based on ParlAIDi… #2973

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

mojtaba-komeili
Copy link
Contributor

Patch description
Fixed the an issue with the documentation for creating new tasks. The fields value that was getting updated in the documentation was outdated.

Copy link
Contributor

@klshuster klshuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix! Would you mind including some screenshots of the rebuilt docs in the description?

Flagging @stephenroller as it doesn't look like all the CI tests ran?

@stephenroller
Copy link
Contributor

This has happened a couple times. File an issue on circleci support saying Circle didn’t trigger and asking for auth refresh. Point them to this PR

@klshuster
Copy link
Contributor

Ticket filed

@mojtaba-komeili
Copy link
Contributor Author

Here is the screenshot of the part that is changed. The changes are highlighted:
Screen Shot 2020-08-12 at 7 07 35 PM

Copy link
Contributor

@klshuster klshuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt this breaks any of the tests that aren't running so gonna go ahead and approve this - thanks again Mojtaba!

@mojtaba-komeili mojtaba-komeili merged commit e339bea into master Aug 13, 2020
@mojtaba-komeili mojtaba-komeili deleted the tasks-doc-updates branch August 13, 2020 14:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants