Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Add custom metrics tutorial #2975

Merged
merged 23 commits into from
Aug 26, 2020
Merged

Add custom metrics tutorial #2975

merged 23 commits into from
Aug 26, 2020

Conversation

stephenroller
Copy link
Contributor

Patch description
Add a tutorial on how we do metrics in ParlAI.

This depends on #2972

Testing steps
Read tutorial. Assigning to @mojtaba-komeili since he is the least familiar with this process, so the best positioned to offer constructive criticism.

image

@stephenroller stephenroller changed the base branch from master to metricsdoc August 12, 2020 23:28
@emilydinan
Copy link
Contributor

what does (real) mean lol

@stephenroller
Copy link
Contributor Author

I originally had this in the other PR, but then realized I needed to make some updates to the doc system, and then decided the previous PR would be where I do that, and this is where I would write the new tutorial.

@stephenroller stephenroller changed the title Add custom metrics tutorial (real) Add custom metrics tutorial Aug 13, 2020
@mojtaba-komeili
Copy link
Contributor

How these metrics are related to model metrics in PyTorch? Is there any visualization tool, for example Tensorboard, that could visualize these metrics?

@stephenroller
Copy link
Contributor Author

All of these metrics are automatically logged to tensorboard if you enable it. That’s a good thing to say.

Copy link
Contributor

@mojtaba-komeili mojtaba-komeili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It reads well. Had a couple of minor comments.

docs/source/tutorial_metrics.md Show resolved Hide resolved
docs/source/tutorial_metrics.md Outdated Show resolved Hide resolved
docs/source/tutorial_metrics.md Outdated Show resolved Hide resolved
Base automatically changed from metricsdoc to master August 23, 2020 13:41
Copy link
Contributor

@jxmsML jxmsML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 👍

docs/source/tutorial_metrics.md Show resolved Hide resolved
@stephenroller stephenroller merged commit 9df7cc3 into master Aug 26, 2020
@stephenroller stephenroller deleted the metricsdocreal branch August 26, 2020 15:00
@stephenroller stephenroller mentioned this pull request Sep 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants