Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

[Chunk Teacher] hidden arg to prevent auto enqueueing #2993

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Conversation

emilydinan
Copy link
Contributor

Patch description
Add a hidden arg to prevent auto enqueuing for chunk teacher. This is useful for multi-threaded counting of the examples in Chunk TEacher.

Copy link
Contributor

@stephenroller stephenroller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the double negative is bad?

if opt.get('auto_enqueues', True)?

@emilydinan emilydinan merged commit 4b257b8 into master Aug 19, 2020
@emilydinan emilydinan deleted the chunkteach branch August 19, 2020 20:18
@stephenroller stephenroller mentioned this pull request Sep 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants