This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
fromfile warning for using valid/test #3063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your PR contains a change to a task. Please paste the results of the following command into a comment: python tests/datatests/test_new_tasks.py |
parlai/tasks/fromfile/agents.py
Outdated
| @@ -83,6 +84,9 @@ def __init__(self, opt, shared=None): | |||
| datafile = opt['fromfile_datapath'] | |||
| if self.opt['fromfile_datatype_extension']: | |||
| datafile += "_" + self.opt['datatype'].split(':')[0] + '.txt' | |||
| else: | |||
| if self.opt['datatype'] == 'valid' or self.opt['datatype'] == 'test': | |||
| logging.warn('You are using this fromfile data as a valid or test set without setting fromfile_datatype_extension to true. Please be aware this uses directly the file you indicated, make sure this is not the same as your training file.') | |||
There was a problem hiding this comment.
I think it's also going to print Batchsize number times. can you add a "if shared is None" protection.
Also I don't think it will handle valid:stream right but that's unusual in fromfile anyway.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.