Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Coverage for more scripts #3110

Merged
merged 7 commits into from
Sep 24, 2020
Merged

Coverage for more scripts #3110

merged 7 commits into from
Sep 24, 2020

Conversation

stephenroller
Copy link
Contributor

Patch description
Add some test coverage for

  • profile_train
  • profile_interactive
  • token_stats
  • distributed_eval

Testing steps
CI/CodeCov

@stephenroller stephenroller changed the title Testmorescripts Coverage for more scripts Sep 23, 2020
Copy link
Contributor

@jxmsML jxmsML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All lgtm. one thing tho is the sample command for profile train parlai profile_train -t babi:task1k:1 -m seq2seq -e 0.1 --dict-file /tmp/dict would fail with with unknown -e

@stephenroller
Copy link
Contributor Author

:O wow good catch, I'll edit that.

@stephenroller stephenroller merged commit 1c43b85 into master Sep 24, 2020
@stephenroller stephenroller deleted the testmorescripts branch September 24, 2020 15:05
stephenroller added a commit that referenced this pull request Sep 28, 2020
# v0.9.3 Release

Known issues
- Short options like `-m` and `-t` do fail in Python 3.8. Use `--model` and `--task`

Breaking Changes
- A number of old MTurk tasks have been archived and removed from the code (#3085)

New Features
- [image] Detectron feature extraction (#3083)
- [data] Natural questions (#3070)
- [data] TaskMaster-2 (#2678)
- [data] New versions of multiwoz (#3072)
- [distributed] Allow non-tcp based distributed setup (#3095)
- [core] Move torch.load/torch.save to PathManager. (#3094, #3077)
- [mturk] New task on static turn annotations (#3053)
- [mturk] New features in human+model annotation (#3006)
- [core] TorchClassifierAgent now prints its number of prameters (#3086)

Doc Changes:
- New Worlds tutorial (#3049)
- Tutorial on using `-t jsonfile` (#3061)
- Better help message for --init-model (#3090)
- Additions to FAQ (#3073)
- Updated model zoo descriptions for BlenderBot (#3096)

Bug Fixes
- Distributed evaluation now writes to world logs earlier (#3122)
- An argument was updated from store_true to bool (#3113)
- Self-chat now fails loudly with unexpected batchsize (#3081)
- Update drqa default tokenizer away from removed (#3069)
- Using wizard of wikipedia in interactive mode downloads data (#3079)

Developer notes:
- New pre-commit git-secrets (#3106)
- Code coverage improvements (#3110, #3091)
- More reliable tests. (#3108, #3097, #3055)
- Mephisto task dependencies have been updates due to security bugs (#3111, #3101, #3104)
- MTurk config folders are exempt from __init__.py requirements (#3105)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants