This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Allow missing args when using --init-opt
#3112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenroller
approved these changes
Sep 30, 2020
tests/test_opt.py
Outdated
|
|
||
| # Assert that the opt file *can* be loaded in if we set | ||
| # --allow-missing-init-opts | ||
| _ = ParlaiParser(True, True).parse_kwargs( |
There was a problem hiding this comment.
do you want to add a check that the resulting opt has the made_up_arg in it?
moyapchen
pushed a commit
that referenced
this pull request
Oct 2, 2020
* Allow missing init opt opts * Add part of unit test * Work on unit test * Test fixes * Fix second test * Fix test * Check obsolete arg does not exist
moyapchen
pushed a commit
that referenced
this pull request
Oct 2, 2020
* Allow missing init opt opts * Add part of unit test * Work on unit test * Test fixes * Fix second test * Fix test * Check obsolete arg does not exist
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Set
--allow-missing-init-opts Trueto be able to load in opt args with--init-opteven if some of the args no longer exist. Also added unit testing of--init-optTesting steps
python -m unittest tests.test_opt