This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Add taskmaster2 command-line arg to specify subset of domains #3135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this change, `parlai dd -t taskmaster2 --display-verbose` displayed a bunch of sports conversations. After this change, running `parlai dd -t taskmaster2 --display-verbose --domains music` displays music conversations. Tried on a few other domains to validate; also had a print in the `_load_data()` function. Also verified that no argument case that all domains were used + defining `domains` multiple times only used the last one.
|
Your PR contains a change to a task. Please paste the results of the following command into a comment: python tests/datatests/test_new_tasks.py |
|
|
Before this change, `parlai dd -t taskmaster2 --display-verbose` displayed a bunch of sports conversations. After this change, running `parlai dd -t taskmaster2 --display-verbose --domains music` displays a music. Also verified that no argument case that all domains were used.
stephenroller
approved these changes
Sep 30, 2020
|
Yeah, it yells at me if I spell things wrong. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Title
Testing steps
Before this change,
parlai dd -t taskmaster2 --display-verbosedisplayed a bunch of sports conversations.After this change, running
parlai dd -t taskmaster2 --display-verbose --domains musicdisplays music conversations. Tried on a few other domains to validate; also had a print in the_load_data()function.Also verified that no argument case that all domains were used +
defining
domainsmultiple times only used the last one.