This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Check directory depending on size param for gpt2 files #3158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| os.path.isfile( | ||
| os.path.join(opt["datapath"], "models", "gpt2_hf", file_name) | ||
| ) | ||
| PathManager.exists(os.path.join(hf_dir, file_name)) |
There was a problem hiding this comment.
lint seems to have caught a bug
stephenroller
approved these changes
Oct 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Earlier distilgpt2 model was trying to load the gpt2 weights and hence failing during runtime. Now we load the files according to the type of the model being loaded
Testing steps
with-proxy python3 parlai/scripts/train_model.py -t integration_tests -m hugging_face/gpt2 -mf /tmp/model --max-train-time 100 -vmt ppl