This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Add "fb" option to autoformat script for parlai_fb
#3165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'f' was already taken by flake, so I just made the single letter code `z`
NOTE: I also fixed a bug where running the autoformatter didn't seem to do anything locally by removing the ellipses after "master" in
```
CHECK_FILES="$(git $REPO diff --name-only master... | grep '\.py$' | reroot $ROOT | onlyexists | tr '\n' ' ')"
```
I have no idea if there are side effects on CircleCI or whatnot from doing this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'f' was already taken by flake, so I just made the single letter code
zNOTE: I also fixed a bug where running the autoformatter didn't seem to do anything locally by removing the ellipses after "master" in
I have no idea if there are side effects on CircleCI or whatnot from doing this.
Testing steps
Add a bunch of empty new lines to the start of files in
parlai,parlai_internal, andparlai_fb. Verify that autoformat appropriately removes these lines while running autoformat with no flag,-i, and-z, respectively.