Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Fix convai2:normalized task's candidate list #3168

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Fix convai2:normalized task's candidate list #3168

merged 1 commit into from
Oct 7, 2020

Conversation

shuuki4
Copy link
Contributor

@shuuki4 shuuki4 commented Oct 7, 2020

Patch description

  • Fix the list of candidates generated by convai2:normalized task.
    • AS-IS code returns normalized labels rather than candidates, which was ruining the evaluation of retrieval based models on this task. (hits@1 always hits 1.0)

stephenroller
stephenroller approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@stephenroller stephenroller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you.

@stephenroller stephenroller merged commit 4d3d1b4 into facebookresearch:master Oct 7, 2020
@shuuki4 shuuki4 deleted the patch-2 branch October 7, 2020 13:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephenroller stephenroller stephenroller approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shuuki4 @stephenroller @facebook-github-bot