Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Make the log rate an adjustable parameter #3189

Merged
merged 2 commits into from
Oct 19, 2020
Merged

Conversation

EricMichaelSmith
Copy link
Contributor

Patch description
Allow the log rate to be adjusted.

Testing steps
Tested by adding a command-line argument (log_rate=60) as well as a line in example.yaml (log_rate: 10)

Copy link
Contributor

@JackUrb JackUrb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made an internal comment about the naming of this (log_rate is pretty vague), but otherwise this is a nice fix.

@EricMichaelSmith
Copy link
Contributor Author

Made an internal comment about the naming of this (log_rate is pretty vague), but otherwise this is a nice fix.

Yes - changed this to monitoring_log_rate for more specificity (it should be assumed that it's for a crowdsourcing task because that's all that we use Hydra for currently)

@EricMichaelSmith EricMichaelSmith merged commit b42ba3e into master Oct 19, 2020
@EricMichaelSmith EricMichaelSmith deleted the log-rate-tuning branch October 19, 2020 20:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants