This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Fix error with using GPT2 + DistributedDataParallel #3207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DistributedDataParallel adds another name to the module path. Fix this. Tested by running GPT2 training with DistributedDataParallel. Also ``` pytest test_gpt2.py::TestDistributed::test_multitask_distributed ``` both with and without the change; verifies it breaks in latter and works in the former.
stephenroller
approved these changes
Oct 20, 2020
klshuster
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
awesome! as a note to @stephenroller I standardized the distributed_train_model command/moved it to testing_utils in #2371 so once that lands we can update this to use that as well
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
DistributedDataParallel adds another name to the module path. Fix this with an if check.
Testing steps
Tested by running GPT2 training with DistributedDataParallel.
Also
both with and without the change; verifies it breaks in latter and passes in the former.