This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Tests for the static turn annotations tasks #3254
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
69bc29d
Dump in what I have so far
EricMichaelSmith ff30337
Starting work on Meph tests
EricMichaelSmith aa7dfc7
Minor
EricMichaelSmith e0d1315
Remove samples
EricMichaelSmith b467aed
Work on static turn annotations unit test
EricMichaelSmith c787729
Formatting file differently
EricMichaelSmith 3346dbf
Minor
EricMichaelSmith ba3a3de
Fixes
EricMichaelSmith 09f6f1c
Minor
EricMichaelSmith 510ec9d
Don't check onboarding for now
EricMichaelSmith b822289
Update convos
EricMichaelSmith d5dd75d
Fixes
EricMichaelSmith 8a08589
Don't have test be mixin
EricMichaelSmith 8c14ca8
Abstract away 1-turn tests
EricMichaelSmith c5d83c0
Fixes
EricMichaelSmith 1b2670a
More tests
EricMichaelSmith b4efd7b
Fixes to 3 tasks
EricMichaelSmith c33f45f
Make tests cleaner
EricMichaelSmith 53d8c34
Remember to build the task
EricMichaelSmith ea6be0d
Test reversion to test
EricMichaelSmith 345d080
Revert config.yml
EricMichaelSmith 36fc211
Merge branch 'master' into turn_annotations_static_testing
EricMichaelSmith 7748efd
Update import
EricMichaelSmith File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nit: would this test break if my ouputs have any time-related values such as timestamp? is the "outputs" where task_start task_end field logged there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, yes, if you have a timestamp in your output, this would break - lemme know if that's a common use case for you and we can find a workaround. The task_start and task_end fields get logged outside "outputs", in their own fields