This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Static turn annotations analysis test fix #3374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
One of today's 4 flaky crowdsourcing tests, visible at https://app.circleci.com/pipelines/github/facebookresearch/ParlAI/8401/workflows/fc283fc3-a00e-4bbf-b816-e407f67f03b5/jobs/68298/steps , occurred when some progress bar appended itself to the actual stdout, meaning that one of the expected lines of output was not an exact match to any of the actual stdout lines. This fix softens that check to just make sure that all of the expected output lines are at least substrings of the actual stdout lines.
Testing steps
pytest tests/crowdsourcing/tasks/turn_annotations_static/test_turn_annotations_static_analysis.py