This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add Last Turn Annotation Only option to turn annotations static task #3436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwillwork
changed the title
Mw/add last annotation
Add Last Turn Annotation Only option to turn annotations static task
Feb 3, 2021
EricMichaelSmith
suggested changes
Feb 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to have this feature! I see that the crowdsourcing checks have failed, perhaps due to having changed the defaults
list in run.py
? I have some other comments, many of which are nits
parlai/crowdsourcing/tasks/turn_annotations_static/conf/example.yaml
Outdated
Show resolved
Hide resolved
parlai/crowdsourcing/tasks/turn_annotations_static/turn_annotations_blueprint.py
Show resolved
Hide resolved
parlai/crowdsourcing/tasks/turn_annotations_static/turn_annotations_blueprint.py
Outdated
Show resolved
Hide resolved
parlai/crowdsourcing/tasks/turn_annotations_static/turn_annotations_blueprint.py
Outdated
Show resolved
Hide resolved
parlai/crowdsourcing/tasks/turn_annotations_static/turn_annotations_blueprint.py
Show resolved
Hide resolved
parlai/crowdsourcing/tasks/turn_annotations_static/turn_annotations_blueprint.py
Outdated
Show resolved
Hide resolved
parlai/crowdsourcing/tasks/turn_annotations_static/turn_annotations_blueprint.py
Outdated
Show resolved
Hide resolved
parlai/crowdsourcing/tasks/turn_annotations_static/turn_annotations_blueprint.py
Outdated
Show resolved
Hide resolved
This PR has not had activity in 30 days. Closing due to staleness. |
EricMichaelSmith
approved these changes
Sep 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes! I just made a fix that will hopefully get the crowdsourcing CI checks to work again so we can merge this in
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Testing steps
Other information