This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Fix valid data file location issue with Natural Questions dataset #3438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Happened to run ``` parlai display_data -t natural_questions -dt valid:stream ``` and ran into an issue about how it couldn't find the files. Digging into the built script and the output directory at `~/ParlAI/data/NaturalQuestions/valid`, I noticed the files were being stored at `nq-dev-00.jsonl` rather than `nq-valid-00.jsonl` as expected by the agent. This does a quick fix to move the files over. Test Plan: Ran the build script, commenting out the steps to redownload + untar all the data. Verified that ``` parlai display_data -t natural_questions -dt valid:stream ``` was indeed successful.
added 2 commits
February 4, 2021 17:48
mojtaba-komeili
approved these changes
Feb 5, 2021
stephenroller
pushed a commit
that referenced
this pull request
Feb 11, 2021
) * Fix valid set issue with Natural Questions dataset Happened to run ``` parlai display_data -t natural_questions -dt valid:stream ``` and ran into an issue about how it couldn't find the files. Digging into the built script and the output directory at `~/ParlAI/data/NaturalQuestions/valid`, I noticed the files were being stored at `nq-dev-00.jsonl` rather than `nq-valid-00.jsonl` as expected by the agent. This does a quick fix to move the files over. Test Plan: Ran the build script, commenting out the steps to redownload + untar all the data. Verified that ``` parlai display_data -t natural_questions -dt valid:stream ``` was indeed successful. * remove print, lol * lint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Happened to run
and ran into an issue about how it couldn't find the files. Digging into the built script and the output directory at
~/ParlAI/data/NaturalQuestions/valid, I noticed the files were being stored atnq-dev-00.jsonlrather thannq-valid-00.jsonlas expected by the agent. This does a quick "move the files over" fix.Test Plan:
Ran the build script, commenting out the steps to redownload + untar all the data. Verified that
was indeed successful.