Skip to content
This repository was archived by the owner on Nov 3, 2023. It is now read-only.

Ignore unimportant coverage lines. #3452

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Ignore unimportant coverage lines. #3452

merged 1 commit into from
Apr 28, 2021

Conversation

stephenroller
Copy link
Contributor

@stephenroller stephenroller commented Feb 12, 2021

Patch description
Stuff in build.py for various teachers only gets called randomly, as we have caches for our data. This patch excludes them from our coverage, as it's up to the cache whether we hit them or not, preventing fluctuations in our coverage.

Testing steps
CI

@github-actions
Copy link

This PR has not had activity in 30 days. Closing due to staleness.

@github-actions github-actions bot added the stale label Mar 26, 2021
@github-actions github-actions bot closed this Apr 2, 2021
@stephenroller stephenroller deleted the coveragehacks branch April 27, 2021 22:49
@stephenroller stephenroller restored the coveragehacks branch April 28, 2021 21:09
@stephenroller stephenroller reopened this Apr 28, 2021
Copy link
Contributor

@klshuster klshuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤑

@stephenroller stephenroller marked this pull request as ready for review April 28, 2021 21:10
@stephenroller stephenroller merged commit f9346e6 into master Apr 28, 2021
@stephenroller stephenroller deleted the coveragehacks branch April 28, 2021 21:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants