This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Make CCPE work #3487
Merged
Make CCPE work #3487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cause it's been a while and Google apparently moved the directory and mildly changed the format of the JSON blob.
klshuster
reviewed
Mar 4, 2021
There was a problem hiding this comment.
your failing teacher tests seem to indicate that you've uncovered a broader issue with google's datasets (I see e.g. taskmaster failing as well...)
failing gpu tests don't seem related.
would you mind also updating the taskmaster URL while you're making this change? I would appreciate it!
stephenroller
approved these changes
Mar 5, 2021
|
The teacher test looks like it could be fixed by merging master into this branch. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cause it's been a while and Google apparently moved the directory and mildly changed the format of the JSON blob.
Ran
parlai dd --task ccpeto test.