Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

How to write a PR contributing (moving to a fork) tutorial #3490

Merged
merged 2 commits into from
Mar 7, 2021
Merged

How to write a PR contributing (moving to a fork) tutorial #3490

merged 2 commits into from
Mar 7, 2021

Conversation

meganung
Copy link
Contributor

@meganung meganung commented Mar 5, 2021

updated CONTRIBUTING.md with instructions on how to move changes that are already committed to a fork.

closes #3409

@meganung meganung requested a review from stephenroller March 5, 2021 07:42
@meganung
Copy link
Contributor Author

meganung commented Mar 5, 2021

#3490 mentions adding links to CONTRIBUTING.md in the docs- it's already linked here, but let me know if we want to make it more visible (e.g. adding a separate section in the sidebar of the docs or in the FAQ, etc.)
Also if there are any formatting preferences feel free to comment!

stephenroller
stephenroller approved these changes Mar 5, 2021
View reviewed changes
Copy link
Contributor

@stephenroller stephenroller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AMAZING THANK YOU!

@stephenroller
Copy link
Contributor

CONTRIBUTING.md can remain the source of truth. I think @spencerp previously resolved the inconsistencies there.

@meganung meganung merged commit 14a2b3f into master Mar 7, 2021
@meganung meganung deleted the pr-contributing-tutorial branch March 7, 2021 09:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephenroller stephenroller stephenroller approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

How to write a PR tutorial in CONTRIBUTING.md
3 participants
@meganung @stephenroller @facebook-github-bot