This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Warning on unrecommended ACUTE-Eval value #3536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackUrb
approved these changes
Mar 18, 2021
| warn_once( | ||
| 'It is *strongly* recommended to use a ' | ||
| 'args.task.maximum_units_per_worker value of 1, as was done in the ' | ||
| 'ACUTE-Eval paper! Go to GitHub Discussions for more information.' |
There was a problem hiding this comment.
A slight change suggestion:
'It is *strongly* recommended to use a '
'args.task.maximum_units_per_worker value of 1, as was done in the '
'ACUTE-Eval paper! Anything else will not provide consistent results as '
'quoted there. Go to ParlAI's GitHub Discussion page '
'if you'd like to discuss further.
I think the current wording implies we already have a discussion on it there.
There was a problem hiding this comment.
Good point, changed
stephenroller
approved these changes
Mar 19, 2021
| from omegaconf import MISSING, DictConfig | ||
|
|
||
| from parlai.crowdsourcing.tasks.acute_eval.acute_eval_agent_state import ( | ||
| AcuteEvalAgentState, | ||
| ) | ||
| from parlai.crowdsourcing.tasks.acute_eval.acute_eval_builder import AcuteEvalBuilder | ||
| from parlai.crowdsourcing.tasks.acute_eval.acute_eval_runner import AcuteEvalRunner | ||
| from parlai.utils.misc import warn_once | ||
|
|
||
| if TYPE_CHECKING: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Print a big ugly warning message if the user tries to set
mephisto.task.maximum_units_per_workerto anything other than the recommended value of 0Testing steps
