Skip to content
This repository was archived by the owner on Nov 3, 2023. It is now read-only.

[ChunkTeacher] Fix infinite padding output #3542

Merged
merged 2 commits into from
Mar 19, 2021

Conversation

emilydinan
Copy link
Contributor

@emilydinan emilydinan commented Mar 19, 2021

Patch description
Returning None here causes an issue where only padding examples are loaded onto the sample queue until we hit a crash. This was most obvious during dynamic batching because a self_observe invariant error was triggered.

Testing steps

 parlai tm -m test_agents/unigram --dict-tokenizer gpt2 -bs 2 -dynb full --truncate 128 -t integration_tests:chunky -mf /tmp/foo -dt train:stream

@emilydinan emilydinan changed the title maybe?? [ChunkTeacher] test fixes Mar 19, 2021
@emilydinan emilydinan marked this pull request as ready for review March 19, 2021 20:04
@stephenroller stephenroller changed the title [ChunkTeacher] test fixes [ChunkTeacher] Fix infinite padding output Mar 19, 2021
@stephenroller stephenroller merged commit 8f41fdf into master Mar 19, 2021
@stephenroller stephenroller deleted the chunkteacherhauntingmeagain branch March 19, 2021 20:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants