This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
If exceptions happen in (all) background workers, currently training just hangs indefinitely while we wait for a batch from the queue. This patch adds a timeout, and checks background workers for exceptions when that timeout is hit. I had previously tested checking on these exceptions before pulling from the queue, but it was devastating to speed. This patch seems to strike a good balance.
In manual testing, this patch displayed these properties:
--num-workers
.Testing steps
Considerable manual testing.