This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[Mutators] full conversation history in flatten mutator #3578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojtaba-komeili
changed the title
parlai/mutators/flatten.py
Outdated
| @@ -23,4 +23,5 @@ def many_episode_mutation(self, episode: List[Message]) -> List[List[Message]]: | |||
| for message in episode: | |||
| history.append(message.pop('text')) | |||
| message['text'] = '\n'.join(history) | |||
| history.extend(message['labels']) | |||
There was a problem hiding this comment.
this should be after the yield, and it shouldn't extend with all of labels. It should pick a random element from labels.
There was a problem hiding this comment.
I can change it to pick one random element from the labels.
Why putting it after yield matters? We have already used history and are not going to use it again until next iterator call. Does it have something to do with the another thread that possibly calls the function?
There was a problem hiding this comment.
You're leaking the label!
There was a problem hiding this comment.
Discussed offline why the implementation is correct, but potentially confusing.
stephenroller
approved these changes
Apr 12, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
flatten mutator was only keeping one side of the conversations in its history and there was losing the context of the conversation after flattening. Keeping the previous labels in the history for having for conversation context.
Testing steps
Used
parlai display_datato compare before and after. See images below:Before:
After:
