This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Modify dictionary load to only rstrip to handle space prefixed tokens #3613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whyyyy didn't this run any tests? |
stephenroller
force-pushed
the
dict_load_fix
branch
from
9556668 to
f7ff11e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
If special tokens are prefixed by space, while loading them from the dict for eval, the space was being stripped out. Modifying the strip to be rstrip and strip only line breaks
Testing steps
Will wait for CI tests to pass