Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

[CMU_DoG] Download data from source #3615

Merged
merged 2 commits into from
Apr 23, 2021
Merged

[CMU_DoG] Download data from source #3615

merged 2 commits into from
Apr 23, 2021

Conversation

spencerp
Copy link
Contributor

@spencerp spencerp commented Apr 22, 2021 •
edited
Loading

Patch description
Instead of using files we host, this pulls the data from where it is hosted by the dataset authors.

Testing steps

parlai dd -t cmu_dog --cmu-dog-split-type original
parlai dd -t cmu_dog
parlai dd -t cmu_dog --cmu-dog-split-type seen
parlai dd -t cmu_dog --cmu-dog-split-type unseen

pytest parlai/tasks/cmu_dog/test.py

@spencerp spencerp requested review from klshuster and moyapchen April 22, 2021 06:36
klshuster
klshuster approved these changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@klshuster klshuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for making this change!

parlai/tasks/cmu_dog/build.py Outdated
def split_into_seen_unseen(dpath: str):
"""
Following WoW, we have overlap in train, valid, and test seen but none in test
valid. Do an 80:10:5:5 split between train, valid, test_seen, test_unseen or as
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: "none in test unseen"

@spencerp spencerp merged commit ccaf473 into master Apr 23, 2021
@spencerp spencerp deleted the cmu-dog-2 branch April 23, 2021 06:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@klshuster klshuster klshuster approved these changes

@moyapchen moyapchen Awaiting requested review from moyapchen

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spencerp @klshuster @facebook-github-bot