This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[task] Fix Cornell Movies #3627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencerp
approved these changes
Apr 29, 2021
| text: The "real you". | ||
| num_episodes: 8310 | ||
| num_examples: 16759 | ||
| num_examples: 13914 |
There was a problem hiding this comment.
Ya but the difference didn't have labels, so they weren't being used for metrics anyway.
There was a problem hiding this comment.
Ah interesting. So it was just eating compute but not directly affecting the model training. Presumably this was effectively reducing the batch size, then.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Cornell movies wasn't properly respecting odd/even conversations, and would produce turns with no labels. This patch fixes that. It also takes the opportunity to migrate the teacher to DialogTeacher, away from our deprecated format.
Manually confirmed that the data folds are the same, and the "less data" now was just blank lines.
Also fix a small typo in TA that surfaced the bug in the first place.
Fixes #3626.
Testing steps
Updated teacher test, and manual train loop