Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

fix acute_eval_blueprint to work with randomize_conversations param #3636

Merged
merged 1 commit into from
Apr 30, 2021
Merged

fix acute_eval_blueprint to work with randomize_conversations param #3636

merged 1 commit into from
Apr 30, 2021

Conversation

kubapok
Copy link
Contributor

@kubapok kubapok commented Apr 30, 2021

Patch description

Testing steps

Other information

@kubapok kubapok mentioned this pull request Apr 30, 2021
Closed
@kubapok
Copy link
Contributor Author

kubapok commented Apr 30, 2021

#3632

stephenroller
stephenroller approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@stephenroller stephenroller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems right to me, but asking for others to check

EricMichaelSmith
EricMichaelSmith approved these changes Apr 30, 2021
View reviewed changes
Copy link
Contributor

@EricMichaelSmith EricMichaelSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@stephenroller stephenroller merged commit 399f7ec into facebookresearch:master Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EricMichaelSmith EricMichaelSmith EricMichaelSmith approved these changes

@stephenroller stephenroller stephenroller approved these changes

@moyapchen moyapchen Awaiting requested review from moyapchen

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kubapok @stephenroller @EricMichaelSmith @facebook-github-bot