This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Fix an issue where usages of
create_agent_from_model_file
caused logging to bump back to INFO.The reason is that we eventually call this line to try to fill in missing args with defaults:
ParlAI/parlai/core/agents.py
Line 368 in 91e883b
Which would get the default args and accidentally call
set_log_level
here:ParlAI/parlai/core/params.py
Line 1158 in 91e883b
As a solution, I moved setting the log level to happen in the abstract ParlaiScript class.
Testing steps
Manual testing.