This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
WikiToxic agents.py slight change #3678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxmsML
reviewed
May 27, 2021
requirements.txt
Outdated
| @@ -43,7 +43,7 @@ tensorboardX==2.1 | |||
| tokenizers>=0.8.0 | |||
| torchtext>=0.5.0 | |||
| tornado==6.0.4 | |||
| tqdm~=4.36.1 | |||
| tqdm~=4.38.0 | |||
There was a problem hiding this comment.
is it from previous merged commits or new one? if it's previously merged commit please rebase on the latest master. if not, I would suggest we separate this into 2 different pull requests.
There was a problem hiding this comment.
yep... it's a previous merge... will try to rebase 👍
jxmsML
approved these changes
Jun 7, 2021
|
@liliarose please check these unit test failures. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Another dataset is using WikiToxic as its parent, but its _get_data() function's error message hardcodes WikiToxic's kaggle dataset source, so changing that to a variable instead.
Testing steps
testing with test.py and also tried parlai display data
passed with
update: I think I tried rebasing it, and then I had to force push it....
Also, the current checks that are failing are failing, I think, because of this:
This build could not be run with the selected resource class. The default Medium resource class was used to run this build. To use the resource class to speed up your build or avoid an out-of-memory error, you can upgrade to a Performance Plan.
Most of them are
Exited with code exit status 1