Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Patch for segment embeddings init #3680

Conversation

wade3han
Copy link
Contributor

Patch description

Added initialization for segment embeddings in transformer encoder. (#3679)
The initialization scheme follows the way initializing the other embeddings.

Testing steps

Other information

@facebook-github-bot
Copy link

Hi @wade3han!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@stephenroller stephenroller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephenroller stephenroller merged commit d07d2dc into facebookresearch:master Jun 2, 2021
@wade3han wade3han deleted the patch/segment_embeddings_init branch June 2, 2021 11:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants