This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Pass opt and kwargs all the way through transformer #3708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaseweston
approved these changes
Jun 11, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Looking at the hash_ladder code, it's apparent there are some more optimizations I could make to the transformer code. This PR:
optthrough to all components that are defined in our codebasekwargsto allforwardfunctionsbuild_layersfunction toTransformerDecoderandTransformerEncoderthat allows for per-layer modificationsTesting steps
working with @jaseweston to make sure I didn't mess anything up; will paste commands ran