This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[eval model] store world logs per task #3718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a test, and also merge the entire bits into the f-string, rather than using concatenation |
jxmsML
force-pushed
the
eval_log
branch
2 times, most recently
from
e672924 to
d79f19d
Compare
kauterry
reviewed
Jul 8, 2021
| return world_logs | ||
| else: | ||
| base_outfile, extension = os.path.splitext(world_logs) | ||
| return f'{base_outfile}_{task}{extension}' |
There was a problem hiding this comment.
Shouldn't it be this?
return f'{base_outfile}_{task}.{extension}'
There was a problem hiding this comment.
No, splitext includes the . In the ext
There was a problem hiding this comment.
the extension contains "."
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Currently when running
parlai em --world-logs .....it only stores the world logs for the very last task if multitasking.This pr would fix this issue by adding the task name as suffix to the world log file path if it's multitasking.
Fixes #3648
Testing steps
Other information