Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Use standard tool for cleaning up metrics #3726

Merged
merged 2 commits into from
Jun 16, 2021
Merged

Use standard tool for cleaning up metrics #3726

merged 2 commits into from
Jun 16, 2021

Conversation

EricMichaelSmith
Copy link
Contributor

Patch description
Use Message.json_safe_payload() for handling serialization of acts instead of manually deleting 'metric' keys.

Testing steps
CI checks

klshuster
klshuster approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@klshuster klshuster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome!

@EricMichaelSmith EricMichaelSmith merged commit 7fe04a4 into master Jun 16, 2021
@EricMichaelSmith EricMichaelSmith deleted the json-safe-payload-crowdsourcing branch June 16, 2021 17:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@klshuster klshuster klshuster approved these changes

@JackUrb JackUrb Awaiting requested review from JackUrb

@stephenroller stephenroller Awaiting requested review from stephenroller

@mus1cholic mus1cholic Awaiting requested review from mus1cholic

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EricMichaelSmith @klshuster @facebook-github-bot