This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
[TGA] Allow setting prefix tokens #3760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 30, 2021 14:59
stephenroller
previously approved these changes
Jul 1, 2021
|
fixed test failure...happened due to spacing issue |
klshuster
approved these changes
Jul 6, 2021
Comment on lines
+1133
to
+1137
| prefix_toks = prefix_tokens[:, _ts] | ||
| prefix_mask = torch.ones_like(score, dtype=torch.bool) | ||
| prefix_mask[ | ||
| :, :, prefix_toks | ||
| ] = False # everything except prefix toks should be neginf |
There was a problem hiding this comment.
thanks this is way cleaner
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Allow the setting of prefix tokens at generation time. This code already existed but was never accessed (and also seemingly did not work). I fixed some bugs in implementation and added a test to confirm that this works.
Testing steps
Wrote a test.